Build statically linked binaries for kubernetes. #5479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ably were generating dynamically linked binaries accidentally.
|
@lavalamp @dchen1107 @thockin |
|
LGTM |
thockin
added
the
lgtm
j3ffml
added a commit
that referenced
this pull request
Mar 16, 2015
Build statically linked binaries for kubernetes.
Closed
vmarmol
added a commit
to vmarmol/kubernetes
that referenced
this pull request
Mar 16, 2015
We allow cgo when available since some of our server components (mainly Kubelet) rely on it. The current driving factor for the static binaries was building Docker images from scratch. We will instead use images built from small busybox bases. Fixes kubernetes#5517
zmerlynn
added a commit
that referenced
this pull request
Mar 16, 2015
Revert #5479, don't force no cgo.
akram
pushed a commit
to akram/kubernetes
that referenced
this pull request
Apr 7, 2015
We allow cgo when available since some of our server components (mainly Kubelet) rely on it. The current driving factor for the static binaries was building Docker images from scratch. We will instead use images built from small busybox bases. Fixes kubernetes#5517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build statically linked binaries. With the change to go 1.4, we probably were generating dynamically linked libraries accidentally.